Cádiz is quite a small city, so I recommend 1 or 2 days to visit the city. If you opt to visit Cádiz in one day, you'll have a more rushed visit, but you still be able to cover the main points of interest. However, if you'd like to explore the city more calmly, then go for two days.