That depends entirely on your preferences. Both places are definitely worth a visit and offer many excursions and activities as well as diving schools. I would say Hurghada is for those looking for more action, Sharm El Sheikh for a quieter holiday or with a focus on diving and snorkelling.