If they had enough supplies, they were VERY GOOD INDEED for the most part 'till cannons got powerful enough to start rendering them obsolete. There's a reason some of castle sieges ended by treachery from within, a HUGE number ended with surrender of the defenders due to starvation, and very few ended by assault.