Don't wear shorts and vests or tank tops. Egypt is a predominately Muslim country and even non-Muslims there are quite conservative. Therefore generally revealing clothing are not recommended. This does not apply if you are visiting Red Sea towns like Sharm-El-Sheikh, Dahab, Marsa Alam and Hurghada.